Skip to content

Conversation

iankhou
Copy link
Contributor

@iankhou iankhou commented Oct 7, 2025

The health_checks workflow fails on the Setup baseline version due to network connectivity issues:
https://github.com/aws-amplify/amplify-backend/actions/runs/18266505828/job/52001722478#logs

Problem

There are no retries on this intermittently failing task.

Changes

Implemented retries in the setup_baseline_version action.

Validation

The workflow run on this PR will validate the change. run-e2e is applied.
Screenshot 2025-10-07 at 12 38 13

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iankhou iankhou self-assigned this Oct 7, 2025
Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: 62eefbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iankhou iankhou added the run-e2e Label that will include e2e tests in PR checks workflow label Oct 7, 2025
@iankhou iankhou closed this Oct 7, 2025
@iankhou iankhou reopened this Oct 7, 2025
@iankhou iankhou marked this pull request as ready for review October 7, 2025 04:07
@iankhou iankhou requested a review from a team as a code owner October 7, 2025 04:07
@iankhou iankhou enabled auto-merge (squash) October 7, 2025 04:50
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/pasting a step? Can we not put a for loop somewhere?

What about other workflows that reuse the setup_base_version workflow fragment? Put the for loop inside that other workflow?

@iankhou iankhou force-pushed the iankhou-e2e_amplify_outputs_backwards_compatibility-retries branch from ec74653 to a7ae1ad Compare October 7, 2025 15:07
@iankhou iankhou force-pushed the iankhou-e2e_amplify_outputs_backwards_compatibility-retries branch from a7ae1ad to 62eefbe Compare October 7, 2025 15:10
@iankhou iankhou changed the title fix: e2e_amplify_outputs_backwards_compatibility only runs once, and often fails on network connectivity issues fix: setup_baseline_version only runs once, and fails often on network instability Oct 7, 2025
@iankhou
Copy link
Contributor Author

iankhou commented Oct 7, 2025

Copy/pasting a step? Can we not put a for loop somewhere?

What about other workflows that reuse the setup_base_version workflow fragment? Put the for loop inside that other workflow?

Implemented this. Thanks for the catch, was copy/pasting due to a limitation when using GitHub Actions instead of scripts, we can't use retries. But retrying at the setup_baseline_version is a much more sustainable approach.

@iankhou iankhou requested a review from rix0rrr October 7, 2025 16:41
@iankhou iankhou merged commit 0dbe1eb into main Oct 7, 2025
305 of 307 checks passed
@iankhou iankhou deleted the iankhou-e2e_amplify_outputs_backwards_compatibility-retries branch October 7, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants